9530 Horn of Hatetalon Loot Fix

[eyerobot]

The horn was made a 100% drop rate back in lich king.

-- 9530 Horn of Hatetalon

DELETE FROM `creature_loot_template` WHERE `entry`=5362 AND `item`=9530;
INSERT INTO `creature_loot_template` (`entry`, `item`, `ChanceOrQuestChance`, `lootmode`, `groupid`, `mincountOrRef`, `maxcount`) VALUES (5362, 9530, -100, 1, 0, 1, 1);
DELETE FROM `creature_loot_template` WHERE `entry`=5363 AND `item`=9530;
INSERT INTO `creature_loot_template` (`entry`, `item`, `ChanceOrQuestChance`, `lootmode`, `groupid`, `mincountOrRef`, `maxcount`) VALUES (5363, 9530, -100, 1, 0, 1, 1);
DELETE FROM `creature_loot_template` WHERE `entry`=5364 AND `item`=9530;
INSERT INTO `creature_loot_template` (`entry`, `item`, `ChanceOrQuestChance`, `lootmode`, `groupid`, `mincountOrRef`, `maxcount`) VALUES (5364, 9530, -100, 1, 0, 1, 1);
DELETE FROM `creature_loot_template` WHERE `entry`=5366 AND `item`=9530;
INSERT INTO `creature_loot_template` (`entry`, `item`, `ChanceOrQuestChance`, `lootmode`, `groupid`, `mincountOrRef`, `maxcount`) VALUES (5366, 9530, -100, 1, 0, 1, 1);

 

[Rhisk]

Looks more organized in this way

-- 9530 Horn of Hatetalon

SET @item=9530;

DELETE FROM `creature_loot_template` WHERE `item`=@item AND `entry` IN (5362, 5363, 5364, 5366);
INSERT INTO `creature_loot_template` (`entry`, `item`, `ChanceOrQuestChance`, `lootmode`, `groupid`, `mincountOrRef`, `maxcount`) VALUES 
(5362, @item, -100, 1, 0, 1, 1),
(5363, @item, -100, 1, 0, 1, 1), 
(5364, @item, -100, 1, 0, 1, 1), 
(5366, @item, -100, 1, 0, 1, 1);

 

[eyerobot]

I know all about that, But it serves no purpose, And none of the tools write it that way. So your going out of your way to rewrite it to do exactly the same thing. If it were some gigantic fix that had a massive amount of lines, Then I would probably do that. And I have done that.
I don't care much for trinitycore's so called standards. So far all it has accomplished is driving off all the developers.

 

[Rhisk]

I use Truice 2.0 sometimes for that.

 

[eyerobot]

Are you saying that truice can label things like that? Because i don't see any options for that.

 

[Rhisk]

I'm sorry the following text has been translated using google:
Not complete but if a part, give the option to generate the full script and then click on the script tab, the code is generated a bit incomplete but organized.
View attachment 1.jpg
View attachment 2.jpg

 

[eyerobot]

You must have entered the data into Truice manually in the creature loot tab.
I tried Keira2 in hopes that it would format my queries according to Trinitycore standards, But it doesn't. In fact I can't find anything that will do that. And reformatting the queries in my Heidisql query window, Just looks stupid.
Yes it looks nice when you use variables in place of numbers. But this database is not compatible with most other databases anyway. So it's not like were waiting for their approval. And if they want one of my fixes that badly, They can reformat it themselves.
As for loot fixes, Yes it makes sense to format it that way. Because it reduces the size of giant queries significantly. But for a quick fix, I won't even bother.

 

[Rhisk]

You are right, this is only useful for the person who revice your fix is easier to verify it and nothing more.

 

[ExO]

Executed to the upcoming release, thanks!