V10 Midsummer event ?!

[Titesusy]

Are mine scripts of midsummer event been missed in V10?
If you want a link to :
https://www.emucoach.com/showthread.php)-cataclysm-server-Midsummer-event

 

[ExO]

Are mine scripts of midsummer event been missed in V10?
If you want a link to :
https://www.emucoach.com/showthread.php/5345-v7-(maybe-older-)-cataclysm-server-Midsummer-event

Hey! It seems like it. I was afraid to run it due to the guids and unfortunately it got out of my head.

Can you please verify that it's still working (because it was for version 7 and a lot has happened since).

What I am must afraid of is that the GUIDS do not match cause of outdate.

So yeah - can you check up on it and see if it works perfectly without issues? Then I will make sure to run it after your confirmation/rework if anything is needed.

 

[Titesusy]

[MENTION=1]ExO[/MENTION]
I can test it but by memory, i don't really use "static" guids. Infact, for these midsummer scripts i used, i worked a lot with multiple requests. The guids are detected by one request which is injected to the real treatment (like the assignement for the gameobject_event table). The real "static" variable i use is for Ids/entries, so it works. But yes, i'll check it before the end of today. I'll repost on this thread to relate the testings.

The code was been rewrite because of displaying on the forum. Indeed, the displaying in "quote" wasn't a good solution because some numbers up to 1000 was formated to 1 000. It could create some displaying bugs.... but now it's fixed by the "code" format (which prevent every typing formats)
The code has been deployed and testings phase will start in a couple of hours - and been completed before midnight)

--
But to agree with you, i'll have to check too the candy buckets because i used a lot the guids (i was starting in sql). I'll check the halloween event after the testing of midsummer

 

[Titesusy]

Hummm ... tested and ok for alliance and horde. If you saw a warning with a bonfire, it goes normally when i restarted the worldserver and the game, clearing the cache. So I don't know.

But It's ok and operational with Horde and Alliance!

The only issue I can see is some fire guards appearing even without the midsummer event... so there are some midsummer keepers added since the v7 (more NPC id to add in the event... i'll look on it as soon as possible)

 

[ExO]

Hummm ... tested and ok for alliance and horde. If you saw a warning with a bonfire, it goes normally when i restarted the worldserver and the game, clearing the cache. So I don't know.

But It's ok and operational with Horde and Alliance!

The only issue I can see is some fire guards appearing even without the midsummer event... so there are some midsummer keepers added since the v7 (more NPC id to add in the event... i'll look on it as soon as possible)

Great! Good to hear.

Would you prefer me to wait with running your queries until you look into the fire guards appearing or should I just execute it now?

 

[Titesusy]

you can execute it now, because anyway, i'll have to add some decorations around some "new" bonfires (like the barrens...)
It's working, so it won't be my priority to check it. And because i didn't looked into event creations with adding multiples objects. When I'll look into it, i'll maybe create an entirly event (like the old Scourge invasion during the pre WOTLK expansion).

So to resume, you can execute the update from today (in the link from the first post, the script is already updated)

 

[ExO]

Great - sounds good!

I've executed it to the server now. Good job by the way.

 

[Titesusy]

you're welcome
You did a nice job with the V10, so !