Fix for quest items dropping as normal loot 7.0.2

[mastermind]

Items for the quest listed below drop as normal loot when you do not have the quest.
The item_loot_template for the three items in question is correct.

Special thanks to ExO for pointing me to the conditions table.

-- -------------------------------------------------------------------------------------------------------
-- Repack version:               7.0.2
-- QuestID 488: Kenn's Binding  - fixes issue for quest items dropping even if you do not have the quest.
-- -------------------------------------------------------------------------------------------------------
DELETE FROM `conditions` WHERE `SourceGroup` IN (2042, 2043, 2033, 14430, 1995, 1996, 1997, 1998, 1999, 2000) AND `SourceEntry` in (3409, 3411, 3412) AND `ConditionValue1` = 488;
INSERT INTO `conditions` (`SourceTypeOrReferenceId`, `SourceGroup`, `SourceEntry`, `SourceId`, `ElseGroup`, `ConditionTypeOrReference`, `ConditionTarget`, `ConditionValue1`, `ConditionValue2`, `ConditionValue3`, `NegativeCondition`, `ErrorType`, `ErrorTextId`, `ScriptName`, `Comment`) VALUES 
(1, 2042, 3409, 0, 1, 9, 0, 488, 0, 0, 0, 0, 0, '', 'Creature Loot, only drop if player has quest'),
(1, 2043, 3409, 0, 1, 9, 0, 488, 0, 0, 0, 0, 0, '', 'Creature Loot, only drop if player has quest'),
(1, 2033, 3409, 0, 1, 9, 0, 488, 0, 0, 0, 0, 0, '', 'Creature Loot, only drop if player has quest'),
(1, 14430, 3409, 0, 1, 9, 0, 488, 0, 0, 0, 0, 0, '', 'Creature Loot, only drop if player has quest'),
(1, 1995, 3411, 0, 1, 9, 0, 488, 0, 0, 0, 0, 0, '', 'Creature Loot, only drop if player has quest'),
(1, 1996, 3411, 0, 1, 9, 0, 488, 0, 0, 0, 0, 0, '', 'Creature Loot, only drop if player has quest'),
(1, 1997, 3411, 0, 1, 9, 0, 488, 0, 0, 0, 0, 0, '', 'Creature Loot, only drop if player has quest'),
(1, 1998, 3412, 0, 1, 9, 0, 488, 0, 0, 0, 0, 0, '', 'Creature Loot, only drop if player has quest'),
(1, 1999, 3412, 0, 1, 9, 0, 488, 0, 0, 0, 0, 0, '', 'Creature Loot, only drop if player has quest'),
(1, 2000, 3412, 0, 1, 9, 0, 488, 0, 0, 0, 0, 0, '', 'Creature Loot, only drop if player has quest');

DELETE FROM `conditions` WHERE `SourceGroup` IN (2042, 2043, 2033, 14430, 1995, 1996, 1997, 1998, 1999, 2000) AND `SourceEntry` in (3409, 3411, 3412) AND `ConditionValue1` IN (2042, 2043, 2033, 14430, 1995, 1996, 1997, 1998, 1999, 2000);
INSERT INTO `conditions` (`SourceTypeOrReferenceId`, `SourceGroup`, `SourceEntry`, `SourceId`, `ElseGroup`, `ConditionTypeOrReference`, `ConditionTarget`, `ConditionValue1`, `ConditionValue2`, `ConditionValue3`, `NegativeCondition`, `ErrorType`, `ErrorTextId`, `ScriptName`, `Comment`) VALUES 
(1, 2042, 3409, 0, 1, 29, 1, 2042, 20, 0, 0, 0, 0, '', 'Creature Loot, only happen if creature distance is 20'),
(1, 2043, 3409, 0, 1, 29, 1, 2043, 20, 0, 0, 0, 0, '', 'Creature Loot, only happen if creature distance is 20'),
(1, 2033, 3409, 0, 1, 29, 1, 2033, 20, 0, 0, 0, 0, '', 'Creature Loot, only happen if creature distance is 20'),
(1, 14430, 3409, 0, 1, 29, 1, 14430, 20, 0, 0, 0, 0, '', 'Creature Loot, only happen if creature distance is 20'),
(1, 1995, 3411, 0, 1, 29, 1, 1995, 20, 0, 0, 0, 0, '', 'Creature Loot, only happen if creature distance is 20'),
(1, 1996, 3411, 0, 1, 29, 1, 1996, 20, 0, 0, 0, 0, '', 'Creature Loot, only happen if creature distance is 20'),
(1, 1997, 3411, 0, 1, 29, 1, 1997, 20, 0, 0, 0, 0, '', 'Creature Loot, only happen if creature distance is 20'),
(1, 1998, 3412, 0, 1, 29, 1, 1998, 20, 0, 0, 0, 0, '', 'Creature Loot, only happen if creature distance is 20'),
(1, 1999, 3412, 0, 1, 29, 1, 1999, 20, 0, 0, 0, 0, '', 'Creature Loot, only happen if creature distance is 20'),
(1, 2000, 3412, 0, 1, 29, 1, 2000, 20, 0, 0, 0, 0, '', 'Creature Loot, only happen if creature distance is 20');

Some of you may point out that the delete statements could have been streamlined. In this case I could have just deleted on the quest id and item id's since all three mobs and items were affected but I like being VERY specific when doing deletes.

 

[ExO]

Really awesome! Saves a lot of time, hope to see more of these!

 

[mastermind]

Happy to contribute where I can.

It's not pages of fixes at a time but it's chipping away at it.