.cheat coodlown fix for 3.3.5

[kamui2040]

Hi,
I'm looking for a solution to the problem that, .cheat cooldown does not work correctly anymore in the newest trinitycore compiles.
You used to be able to spam spells with it, but nowadays most spells still have a cooldown.
I am wondering if someone can tell me how to fix this, I don't understand anything about coding but if someone tells me where and what to change on a freshly pulled trinity source I believe I will be able to do so.
This is the Link to the issue I posted.

Thank you

 

[ExO]

Hi,
I'm looking for a solution to the problem that, .cheat cooldown does not work correctly anymore in the newest trinitycore compiles.
You used to be able to spam spells with it, but nowadays most spells still have a cooldown.
I am wondering if someone can tell me how to fix this, I don't understand anything about coding but if someone tells me where and what to change on a freshly pulled trinity source I believe I will be able to do so.
This is the Link to the issue I posted.

Thank you

So it used to work correctly, but after the newest revision it stopped working correctly? Perhaps it's about finding the commit that caused this and either revert or create a fix through that.

 

[kamui2040]

Unfortunately it isn't the newest that broke it, there is a spawn of at least 1 year where I stopped compiling it myself and with wow completely.
Thus making it retrace it back to a certain commit pretty much impossible, I just thought someone here could know the solution.
I can't tell for sure, but I think I recall this working with this repack. If so wouldn't it be possible to figure out what the difference between the system used in cooldown is?

Edit: I just tested it on 6.0 repack and it is working as it should. It was only a short test though, but maybe you can figure out what the difference is, or where the code that controls the cooldown cheat is in the official trinitycore build? Thanks.

 

[kamui2040]

I've found this entry while browsing the commits on trinityhub, in the spell.cpp.

//Clear spell cooldowns after every spell is cast if .cheat cooldown is enabled.
if (m_caster->ToPlayer()->GetCommandStatus(CHEAT_COOLDOWN))
- m_caster->ToPlayer()->RemoveSpellCooldown(m_spellInfo->Id, true);
+ m_caster->GetSpellHistory()->ResetCooldown(m_spellInfo->Id, true);

how is this handled in the source of 6.0?

 

[ExO]

I've found this entry while browsing the commits on trinityhub, in the spell.cpp.

how is this handled in the source of 6.0?

Good catch! it seems to be handled as the old one of yours:
//Clear spell cooldowns after every spell is cast if .cheat cooldown is enabled.if (m_caster->ToPlayer()->GetCommandStatus(CHEAT_COOLDOWN))
m_caster->ToPlayer()->RemoveSpellCooldown(m_spellInfo->Id, true);

Try reverting it and then test it

 

[kamui2040]

It won't even compile if I revert it.
The errors:

Error 1 error C2039: 'RemoveSpellCooldown' : is not a member of 'Player' D:\Trinity\src\server\game\Spells\Spell.cpp 3320 1 game
Error 2 error LNK1181: cannot open input file '..\game\Release\game.lib' D:\Build\src\server\worldserver\LINK worldserver

 

[ExO]

It won't even compile if I revert it.
The errors:

Cause you must revert the whole commit for it to work properly. Sorry for the slow response.